Missing function Batch Relayer V6 #2550
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubeira
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Real programmers would read from storage or calculate the address by hand, but ok 😛
I knew a guy in college who went a little nuts with defining hot keys in Emacs. I used to joke that I was afraid to use his key bindings, for fear I'd hit the wrong one and accidentally launch the space shuttle. Sorry I wasn't able to do it with all zeroes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered during deployment preparation that the relayer now deploys two contracts: BalancerRelayer, and the new query library contract. In order to verify the query library (and the BalancerRelayer, which takes it as an argument), we need to expose the address of the query library.
Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution